[ARM] Always lower direct calls as direct when the outliner is enabled #66434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The indirect lowering hinders the outliner's ability to see that sequences are in fact common, since the sequence similarity is rendered opaque by the register callee. The size savings from making them indirect seems to be dwarfed by the outliner's savings from de-duplication. rdar://115178034 rdar://115459865
jroelofs
force-pushed
the
jroelofs/rdar115459865
branch
from
1132f40
to
b3cff85
Compare
|
This change looks reasonable to me, but since ARM have a wide corpus of armv7 size sensitive code, could your team evaluate the impact of this change @davemgreen? |
|
Sorry - I managed to run the benchmarks wrong (I was surprised it didn't make any difference). It turns out this does cause some regressions and appears to be worse than before. |
|
Ok, thanks for checking! I'll revert tomorrow. |
jroelofs
added a commit
to jroelofs/llvm-project
that referenced
this pull request
Sep 18, 2023
…s enabled (llvm#66434)" This reverts commit 003bcad. ARM folks say it regresses some of their benchmarks: llvm#66434 (comment)
|
reverted in: 83e6d2e |
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
llvm#66434) The indirect lowering hinders the outliner's ability to see that sequences are in fact common, since the sequence similarity is rendered opaque by the register callee. The size savings from making them indirect seems to be dwarfed by the outliner's savings from de-duplication. rdar://115178034 rdar://115459865
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…s enabled (llvm#66434)" This reverts commit 003bcad. ARM folks say it regresses some of their benchmarks: llvm#66434 (comment)
zahiraam
pushed a commit
to tahonermann/llvm-project
that referenced
this pull request
Oct 24, 2023
…s enabled (llvm#66434)" This reverts commit 003bcad. ARM folks say it regresses some of their benchmarks: llvm#66434 (comment)
zahiraam
pushed a commit
to tahonermann/llvm-project
that referenced
this pull request
Oct 24, 2023
…s enabled (llvm#66434)" This reverts commit 003bcad. ARM folks say it regresses some of their benchmarks: llvm#66434 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indirect lowering hinders the outliner's ability to see that sequences are in fact common, since the sequence similarity is rendered opaque by the register callee. The size savings from making them indirect seems to be dwarfed by the outliner's savings from de-duplication.
rdar://115178034
rdar://115459865