[update_mir_test_checks] Precommit test for multiple defs of vreg #66482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Sep 15, 2023
| ## virtual register (after coming out of SSA form). | ||
|
|
||
| # RUN: cp -f %S/Inputs/multiple-defs.mir %t.mir && %update_mir_test_checks %t.mir | ||
| # RUN: FileCheck %t.mir < %t.mir |
There was a problem hiding this comment.
We normally check the expected generated check lines using diff instead.
There was a problem hiding this comment.
Yeah, I know that's normal, but I'm not sure why it's better. In this case I wanted to demonstrate that the generated checks are broken.
Of course I can do it the "expected" way instead if that's what the reviewers really want.
There was a problem hiding this comment.
Done. I've added the "expected" output, but also run FileCheck to prove that the expected output really works.
XFAIL it until it is fixed by an upcoming commit.
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…vm#66482) XFAIL it until it is fixed by an upcoming commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XFAIL it until it is fixed by an upcoming commit.