-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC][sanitizer_symbolizer]Add StackTracePrinter class #66530
Conversation
@llvm/pr-subscribers-compiler-rt-sanitizer ChangesIntroduce a new virtual class StackTracePrinter and an implementation
|
compiler-rt/lib/sanitizer_common/sanitizer_stacktrace_printer.cpp
Outdated
Show resolved
Hide resolved
compiler-rt/lib/sanitizer_common/tests/sanitizer_stacktrace_printer_test.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With 2 suggestions
Reason: Not including appropiated headers for sanitizer_symbolizer_markup.cpp which only runs in fuchsia. This reverts commit d4152c5.
static StackTracePrinter *GetOrInit(); | ||
|
||
virtual const char *StripFunctionName(const char *function) { | ||
UNIMPLEMENTED(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make these methods pure virtual?
Introduce a new virtual class StackTracePrinter and an implementation FormattedStackTracePrinter in preparation of enabling symbolizer markup for linux. This change allows us to implement other behaviour under the same api for StackTracePrinter, for example, MarkupStackTracePrinter.
Introduce a new virtual class StackTracePrinter and an implementation FormattedStackTracePrinter in preparation of enabling symbolizer markup for linux. This change allows us to implement other behaviour under the same api for StackTracePrinter, for example, MarkupStackTracePrinter.
Introduce a new virtual class StackTracePrinter and an implementation FormattedStackTracePrinter in preparation of enabling symbolizer markup for linux. This change allows us to implement other behaviour under the same api for StackTracePrinter, for example, MarkupStackTracePrinter.
Introduce a new virtual class StackTracePrinter and an implementation
FormattedStackTracePrinter in preparation of enabling symbolizer markup
for linux.
This change allows us to implement other behaviour under the same api
for StackTracePrinter, for example, MarkupStackTracePrinter.