Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SelectionDAG] Flags are dropped when creating FMUL #66646

Closed
wants to merge 1 commit into from
Closed

[SelectionDAG] Flags are dropped when creating FMUL #66646

wants to merge 1 commit into from

Conversation

srpande
Copy link
Contributor

@srpande srpande commented Sep 18, 2023 

While simplifying some vector operators in DAG combine, we may
need to regenerate operators for simplified vectors. At that time,
we need to make sure that all the flags of the new operator
are copied/modified.

Here's an example where "contract" flag is dropped when FMUL
is createted.

Replacing.2 t42: v2f32 = fmul contract t41, t38
With: t48: v2f32 = fmul t38, t38

@llvmbot llvmbot added backend:AMDGPU llvm:SelectionDAG SelectionDAGISel as well labels Sep 18, 2023
@srpande
Copy link
Contributor Author

srpande commented Sep 18, 2023

@changpeng

[SelectionDAG] Flags are dropped when creating a new FMUL
6f91d4d 
While simplifying some vector operators in DAG combine, we may
need to regenerate instructions for simplified vectors. At that time,
we need to make sure that all the flags of the new operator
are copied/modified.

Here's an example where "contract" flag is dropped when FMUL
is createted.

Replacing.2 t42: v2f32 = fmul contract t41, t38
With: t48: v2f32 = fmul t38, t38
@srpande srpande closed this Sep 18, 2023
@srpande srpande deleted the sirish/swdev-397828 branch September 18, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend:AMDGPU llvm:SelectionDAG SelectionDAGISel as well
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srpande @llvmbot