Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC][Bitcode] Remove unused param in DataLayoutCallbackTy #66705

Closed
wants to merge 1 commit into from

Conversation

aeubanks
Copy link
Contributor

No description provided.

@nikic
Copy link
Contributor

nikic commented Sep 19, 2023

The argument was added in https://reviews.llvm.org/D140985.

@jasilvanus
Copy link
Contributor

jasilvanus commented Sep 19, 2023

Thanks @nikic.

We rely downstream on the second argument when importing DXIL in order to fix invalid i8 alignment without using a hardcoded DL string. Instead, we just set natural alignment for i8 in the existing DL string.

I think it's quite natural to feed the DL string of a module into the callback to allow inspection of the existing string?
Maybe we should document the intended usage and downstream dependency better though, not sure on the policy for such things.

@aeubanks
Copy link
Contributor Author

happened to see this when attempting to refactor some code, abandoning

@aeubanks aeubanks closed this Sep 19, 2023
@aeubanks aeubanks deleted the fix branch September 27, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants