Fix the logic in DWARFContext thread safety selection (#11) #66786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch triggered some TSAN reports. Looks like the logic which decided if the thread safe or thread unsafe implementation should be used is inverted. The test is passing with this patch in place.
|
@llvm/pr-subscribers-debuginfo ChangesThe patch triggered some TSAN reports. Looks like the logic which decided if the thread safe or thread unsafe implementation should be used is inverted. The test is passing with this patch in place. Full diff: https://github.com/llvm/llvm-project/pull/66786.diff 1 Files Affected:
diff --git a/llvm/lib/DebugInfo/DWARF/DWARFContext.cpp b/llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
index a45ed0e56553d4e..e338a2ebfc9c2c7 100644
--- a/llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
+++ b/llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
@@ -734,7 +734,7 @@ DWARFContext::DWARFContext(std::unique_ptr<const DWARFObject> DObj,
: DIContext(CK_DWARF),
RecoverableErrorHandler(RecoverableErrorHandler),
WarningHandler(WarningHandler), DObj(std::move(DObj)) {
- if (ThreadSafe)
+ if (!ThreadSafe)
State.reset(new ThreadUnsafeDWARFContextState(*this, DWPName));
else
State.reset(new ThreadSafeState(*this, DWPName));
|
clayborg
approved these changes
Sep 19, 2023
Comment on lines
+737
to
740
| if (!ThreadSafe) | ||
| State.reset(new ThreadUnsafeDWARFContextState(*this, DWPName)); | ||
| else | ||
| State.reset(new ThreadSafeState(*this, DWPName)); |
There was a problem hiding this comment.
It would be nice to just invert this if contents:
if (ThreadSafe)
State.reset(new ThreadSafeState(*this, DWPName));
else
State.reset(new ThreadUnsafeDWARFContextState(*this, DWPName));
|
Because I am github illiterate I pushed the fix directly into mainline. I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch triggered some TSAN reports. Looks like the logic which decided if the thread safe or thread unsafe implementation should be used is inverted. The test is passing with this patch in place.