[PowerPC] Do not string pool globals that are part of llvm used. #66848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanp-ibm
requested review from
hubert-reinterpretcast,
amy-kwan and
lei137
hubert-reinterpretcast
approved these changes
Oct 19, 2023
lei137
approved these changes
Nov 7, 2023
| @llvm.used = appending global [1 x ptr] [ptr @keep_this], section "llvm.metadata" | ||
| @llvm.compiler.used = appending global [1 x ptr] [ptr @keep_this2], section "llvm.metadata" | ||
|
|
||
| declare signext i32 @callee(ptr noundef) local_unnamed_addr |
There was a problem hiding this comment.
I don't think local_unnamed_addr does anything here does it? If not can we remove that and the #0 from blow. Thx
stefanp-ibm
force-pushed
the
stefanp/StringPoolingUsedFix
branch
from
5ae27d2
to
d03571a
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
The string pooling pass was incorrectly pooling global varables that were part of llvm.used or llvm.compiler.used. This patch fixes the pass to prevent that by checking each candidate to make sure that it is not in either of those lists.
stefanp-ibm
force-pushed
the
stefanp/StringPoolingUsedFix
branch
from
d03571a
to
0383c03
Compare
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Nov 30, 2023
Local branch amd-gfx 741a0a2 Merged main:d9962c400f97 into amd-gfx:8bf360256d7b Remote branch main d896b1f [PowerPC] Do not string pool globals that are part of llvm used. (llvm#66848)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string pooling pass was incorrectly pooling global varables that were part of llvm.used or llvm.compiler.used. This patch fixes the pass to prevent that by checking each candidate to make sure that it is not in either of those lists.