Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-docs: Add option to disable doxygen/sphinx docs #66928

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

tru
Copy link
Collaborator

@tru tru commented Sep 20, 2023

Doxygen documentation takes very long to build, when making releases we
want to get the normal documentation up earlier so that we don't have to
wait for doxygen documentation.

This PR just adds the flag to disable doxygen builds, I will then later
make a PR that changes the actions to first build the normal docs and
another job to build the doxygen docs.

@tru tru requested a review from tstellar September 20, 2023 16:41
Doxygen documentation takes very long to build, when making releases we
want to get the normal documentation up earlier so that we don't have to
wait for doxygen documentation.

This PR just adds the flag to disable doxygen builds, I will then later
make a PR that changes the actions to first build the normal docs and
another job to build the doxygen docs.
@tru tru changed the title build-docs: Add option to disable doxygen docs build-docs: Add option to disable doxygen/sphinx docs Sep 21, 2023
Comment on lines 105 to 116
if [ "$no_sphinx" != "yes" ]; then
sphinx_targets="docs-clang-html docs-clang-tools-html docs-flang-html docs-lld-html docs-llvm-html docs-polly-html"
sphinx_flag=" -DLLVM_ENABLE_SPHINX=ON -DSPHINX_WARNINGS_AS_ERRORS=OFF"
fi

if [ "$no_doxygen" != "yes" ]; then
echo "Doxygen: enabled"
doxygen_targets="$docs_target doxygen-clang doxygen-clang-tools doxygen-flang doxygen-llvm doxygen-mlir doxygen-polly"
doxygen_flag=" -DLLVM_ENABLE_DOXYGEN=ON -DLLVM_DOXYGEN_SVG=ON"
else
echo "Doxygen: disabled"
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you print a message for doxygen and not sphinx? I think we should be consistent here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I added the -no-sphinx option later and just forgot. I will fix so that it always writes status for both.

@cor3ntin
Copy link
Contributor

This PR just adds the flag to disable doxygen builds, I will then later
make a PR that changes the actions to first build the normal docs and
another job to build the doxygen docs.

Maybe the doxygen build should be a nightly job?

@tru
Copy link
Collaborator Author

tru commented Sep 22, 2023

This PR just adds the flag to disable doxygen builds, I will then later
make a PR that changes the actions to first build the normal docs and
another job to build the doxygen docs.

Maybe the doxygen build should be a nightly job?

Yes maybe. But I want to make sure that we build doxygen docs for the release tag. I just need to separate it out, waiting for the job to finish (and sometimes fail!) makes releasing a new version very frustrating.

Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! (i needed that feature a few days ago :) )

@tru tru merged commit fe7fe6d into llvm:main Sep 22, 2023
1 of 2 checks passed
@tru tru deleted the tru/build_docs branch September 22, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants