Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlir][sparse] Generates python bindings for SparseTensorTransformOps. #66937

Merged
merged 3 commits into from
Sep 20, 2023
Merged

[mlir][sparse] Generates python bindings for SparseTensorTransformOps. #66937

merged 3 commits into from
Sep 20, 2023

Conversation

PeimingLiu
Copy link
Member

No description provided.

@llvmbot llvmbot added mlir:python MLIR Python bindings mlir labels Sep 20, 2023
ftynse
ftynse reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@ftynse ftynse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test, just to make sure the extension is loaded correctly?

@PeimingLiu
Copy link
Member Author

Can we have a test, just to make sure the extension is loaded correctly?

Do you have a pointer to a pre-existing test for me?

@PeimingLiu
Copy link
Member Author

Can we have a test, just to make sure the extension is loaded correctly?

Do you have a pointer to a pre-existing test for me?

NVM, found them under the test folder, will do!

@PeimingLiu PeimingLiu merged commit 3d27d11 into llvm:main Sep 20, 2023
2 of 3 checks passed
@PeimingLiu PeimingLiu deleted the piper_export_cl_567024395 branch September 20, 2023 22:51
@kstoimenov kstoimenov mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftynse ftynse ftynse approved these changes

@aartbik aartbik aartbik left review comments

@yinying-lisa-li yinying-lisa-li yinying-lisa-li approved these changes

@nicolasvasilache nicolasvasilache Awaiting requested review from nicolasvasilache

Assignees
No one assigned
Labels
mlir:python MLIR Python bindings mlir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PeimingLiu @ftynse @aartbik @yinying-lisa-li @llvmbot