Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMDGPU] Add pal metadata 3.0 support to callable pal funcs #67104

Merged
merged 10 commits into from
Feb 6, 2024
Merged

[AMDGPU] Add pal metadata 3.0 support to callable pal funcs #67104

merged 10 commits into from
Feb 6, 2024

Conversation

dstutt
Copy link
Collaborator

@dstutt dstutt commented Sep 22, 2023

No description provided.

@dstutt
Copy link
Collaborator Author

dstutt commented Sep 22, 2023

@llvm/pr-subscribers-amdgpu

@dstutt
Copy link
Collaborator Author

dstutt commented Sep 22, 2023

@llvm/pr-subscribers-backend-amdgpu

@dstutt dstutt requested a review from a team September 22, 2023 09:32
@dstutt
Copy link
Collaborator Author

dstutt commented Sep 28, 2023

ping

Note: this is just an extension of fc83f1d [AMDGPU] Add backend support for new PAL ELF Metadata 3.0

@dstutt
[AMDGPU] Add pal metadata 3.0 support to callable pal funcs
e622475 
PAL Metadata 3.0 introduces an explicit structure in metadata for the
programmable registers written out by the compiler backend.
The previous approach used opaque registers which can change between different
architectures and required encoding the bitfield information in the backend,
which may change between versions.

This change is an extension the previously added support - which only handled
entry functions. This adds support for all functions.

The change also includes some re-factoring to separate common code.
perlfu
perlfu approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@perlfu perlfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one comment related nit inline

llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h Outdated Show resolved Hide resolved
arsenm
arsenm reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@arsenm arsenm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping, is this still relevant?

@dstutt
Copy link
Collaborator Author

dstutt commented Feb 1, 2024

Yes, this is still relevant (sorry, I had forgotten about it).
Just double checking that extra changes are not required after recent update to getPGMRSrc1.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited

✅ With the latest revision this PR passed the C/C++ code formatter.

@dstutt dstutt merged commit d6c7253 into llvm:main Feb 6, 2024
4 of 5 checks passed
perlfu added a commit that referenced this pull request Feb 7, 2024
@perlfu
Revert "[AMDGPU] Add pal metadata 3.0 support to callable pal funcs (#…
7d508eb 
…67104)"

This reverts commit d6c7253.

Change causing CTS failures due to incomplete metadata.
perlfu added a commit that referenced this pull request Mar 14, 2024
@perlfu
Reapply "[AMDGPU] Add pal metadata 3.0 support to callable pal funcs (#…
c29b265 
…67104)"

This reverts commit 7d508eb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrAMD piotrAMD piotrAMD left review comments

@arsenm arsenm arsenm approved these changes

@perlfu perlfu perlfu approved these changes

Assignees
No one assigned
Labels
backend:AMDGPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dstutt @arsenm @perlfu @piotrAMD