Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Passes] Add option for LoopVersioningLICM pass. #67107

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

lcvon007
Copy link
Contributor

@lcvon007 lcvon007 commented Sep 22, 2023

User only can use opt to test LoopVersioningLICM pass, and this PR add the option back(deleted in https://reviews.llvm.org/D137915) so that it's easy for verifying if it is useful for some benchmarks.

@aeubanks
Copy link
Contributor

I'm unsure of the placement of this in the pipeline, adding people who may have more context.

Can you add a description for what you'd like to do with this in the long run?

@lcvon007
Copy link
Contributor Author

I'm unsure of the placement of this in the pipeline, adding people who may have more context.

Can you add a description for what you'd like to do with this in the long run?

May you explain the reason that deletes this option for Loop Versioning LICM pass in https://reviews.llvm.org/D137915 ? I think it may be helpful with this option if someone want to verify it.

User only can use opt to test LoopVersioningLICM pass before,
and this PR adds the option back(deleted in https://reviews.llvm.org/D137915)
so that it's easy for verifying if it is useful for some benchmarks.
@lcvon007 lcvon007 merged commit f3c417f into llvm:main Sep 27, 2023
3 checks passed
@lcvon007 lcvon007 deleted the enable-loop-version-licm branch September 27, 2023 12:39
legrosbuffle pushed a commit to legrosbuffle/llvm-project that referenced this pull request Sep 29, 2023
User only can use opt to test LoopVersioningLICM pass, and this PR add
the option back(deleted in https://reviews.llvm.org/D137915) so that
it's easy for verifying if it is useful for some benchmarks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants