Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM] Add writeback information to STC and LDC instructions. #67180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rot127
Copy link

@Rot127 Rot127 commented Sep 22, 2023

LDC and STC were missing the write-back register.

Copy link

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure seems unrelated:

FAILED: unittests/tools/llvm-profgen/LLVMProfgenTests.exe
--
  | cmd.exe /C "cd . && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E vs_link_exe --intdir=unittests\tools\llvm-profgen\CMakeFiles\LLVMProfgenTests.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe" --manifests  -- C:\BuildTools\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64\link.exe /nologo unittests\tools\llvm-profgen\CMakeFiles\LLVMProfgenTests.dir\ContextCompressionTest.cpp.obj unittests\tools\llvm-profgen\CMakeFiles\LLVMProfgenTests.dir\__\__\__\resources\windows_version_resource.rc.res  /out:unittests\tools\llvm-profgen\LLVMProfgenTests.exe /implib:unittests\tools\llvm-profgen\LLVMProfgenTests.lib /pdb:unittests\tools\llvm-profgen\LLVMProfgenTests.pdb /version:0.0 /machine:x64 /STACK:10000000 /INCREMENTAL:NO /subsystem:console  lib\LLVMSupport.lib  lib\LLVMSupport.lib  lib\llvm_gtest_main.lib  lib\llvm_gtest.lib  lib\LLVMTestingSupport.lib  lib\llvm_gtest.lib  lib\LLVMSupport.lib  psapi.lib  shell32.lib  ole32.lib  uuid.lib  advapi32.lib  delayimp.lib  -delayload:shell32.dll  -delayload:ole32.dll  lib\LLVMDemangle.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
  | MT: command "C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe /nologo /manifest unittests\tools\llvm-profgen\LLVMProfgenTests.exe.manifest /outputresource:unittests\tools\llvm-profgen\LLVMProfgenTests.exe;#1" failed (exit code 0x1f) with the following output:
  |  
  | mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "unittests\tools\llvm-profgen\LLVMProfgenTests.exe". Operation did not complete successfully because the file contains a virus or potentially unwanted software.
  | [9679/9687] Linking CXX executable unittests\tools\llvm-exegesis\LLVMExegesisTests.exe
  | [9681/9687] Linking CXX executable tools\clang\unittests\Tooling\ToolingTests.exe
  | ninja: build stopped: subcommand failed.

@AtariDreams
Copy link
Contributor

Ping?

@Rot127
Copy link
Author

Rot127 commented Mar 30, 2024

It is still on the todo list. Sorry for letting it run stale. Will update it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants