Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libunwind] Pass -Wl,--export-dynamic on all supported platforms #67205

Merged
merged 1 commit into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. [libunwind] Pass -Wl,--export-dynamic on all supported platforms

    I was trying to run the tests on FreeBSD and noticed that we weren't
    printing symbol names. It turns out this is because of the missing
    -Wl,--export-dynamic flag. Instead of hardcoding the name of the flag
    and only passing it for Linux hosts, use a pre-existing CMake variable
    instead. I was not aware of this flag, but it appears to have been
    supported for the past 16 years (with support for more platforms added
    later): https://gitlab.kitware.com/cmake/cmake/-/commit/66d1930f5674f08e09f455b3f0777f2de3e0717e
    arichardson committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    27c0526 View commit details
    Browse the repository at this point in the history