[BOLT][NFC] Extract a function for dump MCInst #67225
Conversation
|
In GDB debugging, sometimes I want to obtain the assembly representation of an MCInst, as it would be more intuitive. However, it seems that such an interface is currently lacking, So I thought maybe we should add one. |
bolt/lib/Core/BinaryFunction.cpp
Outdated
| @@ -389,6 +389,13 @@ bool BinaryFunction::isForwardCall(const MCSymbol *CalleeSymbol) const { | |||
| } | |||
| } | |||
|
|
|||
| void BinaryFunction::dump(const MCInst &Inst) const { | |||
| if (!BC.InstPrinter) | |||
There was a problem hiding this comment.
It seems to me it is more of a BC interace, not BF. Also suggest you to write something on if instprinter is not ready.
Anyway it needs to be used somehow, it could not be just merged without proper usage, tests & etc
There was a problem hiding this comment.
Oh, thanks for your suggestion. I will try to modify it to BC interface and add test cases or usage, for testing purposes.
llongint
changed the title
llongint
changed the title
|
ping. |
|
Hi, @aaupov @maksfb @rafaelauler , can I merge this debugging assistance interface? |
Extract a function for printing MCInst, so we can call it in GDB to get a more intuitive assembly representation.
Thanks, modified. |
In GDB debugging, obtaining the assembly representation of MCInst is more intuitive.