[scudo] Mark page status in getStats in secondary

[ChiaHungDuan]

Cache entry marked with [R] indicates that the pages have been released by releaseToOS().

[llvmbot]

@llvm/pr-subscribers-compiler-rt-sanitizer

Changes

Cache entry marked with [R] indicates that the pages have been released by releaseToOS().

---

Full diff: https://github.com/llvm/llvm-project/pull/67588.diff

1 Files Affected:

• (modified) compiler-rt/lib/scudo/standalone/secondary.h (+2-2)

diff --git a/compiler-rt/lib/scudo/standalone/secondary.h b/compiler-rt/lib/scudo/standalone/secondary.h
index d0890d1c5e2d3d5..9302c226cba0a26 100644
--- a/compiler-rt/lib/scudo/standalone/secondary.h
+++ b/compiler-rt/lib/scudo/standalone/secondary.h
@@ -174,9 +174,9 @@ template <typename Config> class MapAllocatorCache {
       if (!Entry.isValid())
         continue;
       Str->append("StartBlockAddress: 0x%zx, EndBlockAddress: 0x%zx, "
-                  "BlockSize: %zu\n",
+                  "BlockSize: %zu %s\n",
                   Entry.CommitBase, Entry.CommitBase + Entry.CommitSize,
-                  Entry.CommitSize);
+                  Entry.CommitSize, Entry.Time == 0 ? "[R]" : " ");
     }
   }
 

[cferris1000]

I know this is a really, really small nit, but could this be modified slightly so there is no whitespace at the end?

For example:

BlockSize: %zu%s\n", ..., EntryTime == 0 ? " [R]" : "");

[ChiaHungDuan]

Sorry, I was under the impression that we have to have non-empty string in ScopedString for the placeholder and I was wrong.

Fixed