New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] [Coverage] Do not use recursion for getMaxCounterID #67870

Merged

jroelofs merged 1 commit into llvm:main from shen3qing1:norecurse2

Oct 2, 2023

Contributor

shen3qing1 commented Sep 30, 2023

This causes stack overflows for real-world coverage reports.

Tested with build/bin/llvm-lit -a llvm/test/tools/llvm-cov


          [NFC] [Coverage] Do not use recursion for getMaxCounterID

7dd3dc8

This causes stack overflows for real-world coverage reports.

Contributor Author

shen3qing1 commented Sep 30, 2023

@jroelofs @MaskRay PTAL thanks!

jroelofs merged commit 3f417a7 into llvm:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment