[Target] Change no-trap-after-noreturn to trap-after-noreturn

[chsigg]

This was suggested in 5b7a7ec to avoid too many negates (e.g. !NoTrapAfterNoreturn).

[chsigg]

The buildkite failure is unrelated to this PR. The culprit is commit 6403287.

[nikic]

Please add a patch description justifying this change. As-is, this seems like a pointless rename to me.

[Artem-B]

Please add a patch description justifying this change. As-is, this seems like a pointless rename to me.

I've suggested renaming it to improve readability. Double negations in a single word are already hard to read, and when it's used in a negation, !NoTrapAfterNoreturn looks outright odd to me.

We don't need these changes, but I think it's a nice cleanup.

[nikic]

NoTrapAfterNoreturn is a modifier on TrapUnreachable. You enable traps and then disable some of them again. If you formulate this positively, it looks like TrapAfterNoreturn=true should work independently of TrapUnreachable (insert traps after noreturn calls only), which is not how this actually works.

[Artem-B]

OK. If the naming was intentional, I'm fine keeping it as is.

[MaskRay]

OK. If the naming was intentional, I'm fine keeping it as is.

I think a variable with a positive meaning (TrapAfterNoreturn) is preferred. You could make the change non-functional.

It's just that how TrapAfterNoreturn is set to true and false should be thought carefully.

[chsigg]

I had considered that, but didn't like the idea of variable names not matching the flag name. I also think Nikita's concerns would still apply, because it's common to configure this through TargetOptions, not through command line arguments.