-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover performance loss after PagedVector introduction #67972
base: main
Are you sure you want to change the base?
Conversation
@nikic any suggestion on how can I run the performance benchmark myself? |
Not seeing a difference in |
Moves from 42 elements (automatically calculated) to 32. It should both reduce memory usage (it does at least in my test) and avoid the need for a division when indexing the elements.
@nikic I have pushed a new commit where I change the size of the page to 32 elements from the current 42. It should at least get rid of a division. |
Should we abandon this? |
I have updated the branch and I think the two changes in this PR are in any case good. However it's my understanding that the performance regression was actually due to some less aggressive inlining of the new code. I have no idea how to proceed for that though. |
No description provided.