[llvm-profgen] Print DWP related warnings under show-detailed-warning

[htyu]

Printing DWP related warnings under show-detailed-warning so that they won't flood user log.

[llvmbot]

@llvm/pr-subscribers-pgo

Changes

Printing DWP related warnings under show-detailed-warning so that they won't flood user log.

---

Full diff: https://github.com/llvm/llvm-project/pull/68019.diff

1 Files Affected:

• (modified) llvm/tools/llvm-profgen/ProfiledBinary.cpp (+13-7)

diff --git a/llvm/tools/llvm-profgen/ProfiledBinary.cpp b/llvm/tools/llvm-profgen/ProfiledBinary.cpp
index f26b2bd5df5eda5..eade3b46bce773a 100644
--- a/llvm/tools/llvm-profgen/ProfiledBinary.cpp
+++ b/llvm/tools/llvm-profgen/ProfiledBinary.cpp
@@ -810,24 +810,30 @@ void ProfiledBinary::loadSymbolsFromDWARF(ObjectFile &Obj) {
     loadSymbolsFromDWARFUnit(*CompilationUnit.get());
 
   // Handles DWO sections that can either be in .o, .dwo or .dwp files.
+  uint32_t NumOfDWOMissing = 0;
   for (const auto &CompilationUnit : DebugContext->compile_units()) {
     DWARFUnit *const DwarfUnit = CompilationUnit.get();
     if (DwarfUnit->getDWOId()) {
       DWARFUnit *DWOCU = DwarfUnit->getNonSkeletonUnitDIE(false).getDwarfUnit();
       if (!DWOCU->isDWOUnit()) {
-        std::string DWOName = dwarf::toString(
-            DwarfUnit->getUnitDIE().find(
-                {dwarf::DW_AT_dwo_name, dwarf::DW_AT_GNU_dwo_name}),
-            "");
-        WithColor::warning()
-            << "DWO debug information for " << DWOName
-            << " was not loaded. Please check the .o, .dwo or .dwp path.\n";
+        NumOfDWOMissing++;
+        if (ShowDetailedWarning) {
+          std::string DWOName = dwarf::toString(
+              DwarfUnit->getUnitDIE().find(
+                  {dwarf::DW_AT_dwo_name, dwarf::DW_AT_GNU_dwo_name}),
+              "");
+          WithColor::warning()
+              << "DWO debug information for " << DWOName
+              << " was not loaded. Please check the .o, .dwo or .dwp path.\n";
+        }
         continue;
       }
       loadSymbolsFromDWARFUnit(*DWOCU);
     }
   }
 
+  if (NumOfDWOMissing)
+    WithColor::warning() << NumOfDWOMissing << " DWO not loaded\n";
   if (BinaryFunctions.empty())
     WithColor::warning() << "Loading of DWARF info completed, but no binary "
                             "functions have been retrieved.\n";

[WenleiHe]

How about this:

For detailed warning, simply say "DWO debug information for .. was not loaded."

For the summary warning below, say "DWO debug information was not loaded for N modules, Please check the .o, .dwo or .dwp path."

[htyu]

Sounds good.

[WenleiHe]

, Please -> . Please