[WIP][-Wunsafe-buffer-usage] Generalize DerefSimplePtrArithFixableGadget to non-literals

[jkorous-apple]

No description provided.

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff 93e0127b5036602d786a45f76c6daac67c590723 998d7174049deb0ec319155e3740b2d9031d2ff0 -- clang/lib/Analysis/UnsafeBufferUsage.cpp

View the diff from clang-format here.

diff --git a/clang/lib/Analysis/UnsafeBufferUsage.cpp b/clang/lib/Analysis/UnsafeBufferUsage.cpp
index 062f57bf36b2..56e3be11d935 100644
--- a/clang/lib/Analysis/UnsafeBufferUsage.cpp
+++ b/clang/lib/Analysis/UnsafeBufferUsage.cpp
@@ -1005,9 +1005,8 @@ public:
         AddOp(Result.Nodes.getNodeAs<BinaryOperator>(AddOpTag)),
         OffsetLiteral(Result.Nodes.getNodeAs<IntegerLiteral>(OffsetLiteralTag)),
         OffsetUnsigned(Result.Nodes.getNodeAs<Expr>(OffsetUnsignedTag)) {
-        assert(OffsetLiteral || OffsetUnsigned && "Expecting some RHS");
-      }
-
+    assert(OffsetLiteral || OffsetUnsigned && "Expecting some RHS");
+  }
 
   static Matcher matcher() {
     // clang-format off