Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISCV][AArch64] Don't allow -mvscale-min/max options to be passed to the clang driver. #68065

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Oct 3, 2023

The driver doesn't have code to pass these down to cc1. It just prints an unused option warning. Remove them from the driver.

… the clang driver.

The driver doesn't have code to pass these down to cc1. It just
prints an unused option warning. Remove them from the driver.
@topperc topperc added the clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' label Oct 3, 2023
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Oct 3, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Oct 3, 2023

@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-backend-aarch64

@llvm/pr-subscribers-backend-risc-v

Changes

The driver doesn't have code to pass these down to cc1. It just prints an unused option warning. Remove them from the driver.


Full diff: https://github.com/llvm/llvm-project/pull/68065.diff

1 Files Affected:

  • (modified) clang/include/clang/Driver/Options.td (+2-4)
diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td
index ee4e23f335e7875..87159dd64dc7a7b 100644
--- a/clang/include/clang/Driver/Options.td
+++ b/clang/include/clang/Driver/Options.td
@@ -4563,13 +4563,11 @@ def msve_vector_bits_EQ : Joined<["-"], "msve-vector-bits=">, Group<m_aarch64_Fe
 } // let Flags = [TargetSpecific]
 
 def mvscale_min_EQ : Joined<["-"], "mvscale-min=">,
-  Group<m_aarch64_Features_Group>, Flags<[NoXarchOption]>,
-  Visibility<[ClangOption, CC1Option, FC1Option]>,
+  Visibility<[CC1Option, FC1Option]>,
   HelpText<"Specify the vscale minimum. Defaults to \"1\". (AArch64/RISC-V only)">,
   MarshallingInfoInt<LangOpts<"VScaleMin">>;
 def mvscale_max_EQ : Joined<["-"], "mvscale-max=">,
-  Group<m_aarch64_Features_Group>, Flags<[NoXarchOption]>,
-  Visibility<[ClangOption, CC1Option, FC1Option]>,
+  Visibility<[CC1Option, FC1Option]>,
   HelpText<"Specify the vscale maximum. Defaults to the"
            " vector length agnostic value of \"0\". (AArch64/RISC-V only)">,
   MarshallingInfoInt<LangOpts<"VScaleMax">>;

@topperc topperc merged commit 8092933 into llvm:main Oct 3, 2023
7 checks passed
@topperc topperc deleted the pr/vscale-min-max branch October 3, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:AArch64 backend:RISC-V clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants