[clang] NFC: Remove unused FileEntry::getLastRef()
#68156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang ChangesThe last usage of the deprecated Full diff: https://github.com/llvm/llvm-project/pull/68156.diff 1 Files Affected:
diff --git a/clang/include/clang/Basic/FileEntry.h b/clang/include/clang/Basic/FileEntry.h
index c377aba2c1d2ebd..23237a9326f84b6 100644
--- a/clang/include/clang/Basic/FileEntry.h
+++ b/clang/include/clang/Basic/FileEntry.h
@@ -426,7 +426,6 @@ class FileEntry {
public:
~FileEntry();
StringRef getName() const { return LastRef->getName(); }
- FileEntryRef getLastRef() const { return *LastRef; }
StringRef tryGetRealPathName() const { return RealPathName; }
off_t getSize() const { return Size; }
|
benlangmuir
approved these changes
Oct 3, 2023
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Oct 4, 2023
Revert: breaks hipify 25a6b89: [clang] NFC: Remove unused `FileEntry::getLastRef()` (llvm#68156) Change-Id: I8ba7c4c9eb08b63a479c2c393ace3195c2f5b5b0
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Oct 6, 2023
The last usage of the deprecated `FileEntry::getLastRef()` was removed in llvm#67838, let's remove it entirely. Change-Id: I690b9a38b8d9e7b4c1414d008873f3f819a27a26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last usage of the deprecated
FileEntry::getLastRef()was removed in #67838, let's remove it entirely.