Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang-repl] Disable InterpreterExceptionTest on RISC-V #68216

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

asb
Copy link
Contributor

@asb asb commented Oct 4, 2023

This test fails as .eh_frame handling is not yet implemented for RISC-V in JITLink. #66067 is proposed to address this.

Skip the test until the issue is resolved. It seems that D159167 enabled this test for more than just ppc64. As the test always failed, it just wasn't run until now, I think skipping is the correct interim approach (as is already done for Arm, Darwin, and others).

This test fails as .eh_frame handling is not yet implemented for RISC-V
in JITLink. llvm#66067 is proposed to address this.

Skip the test until the issue is resolved. It seems that D159167
enabled this test for more than just ppc64.
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Oct 4, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Oct 4, 2023

@llvm/pr-subscribers-clang

Changes

This test fails as .eh_frame handling is not yet implemented for RISC-V in JITLink. #66067 is proposed to address this.

Skip the test until the issue is resolved. It seems that D159167 enabled this test for more than just ppc64. As the test always failed, it just wasn't run until now, I think skipping is the correct interim approach (as is already done for Arm, Darwin, and others).


Full diff: https://github.com/llvm/llvm-project/pull/68216.diff

1 Files Affected:

  • (modified) clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp (+5)
diff --git a/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp b/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
index 2f1c4efb381f00b..7b47d93446192ba 100644
--- a/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
+++ b/clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp
@@ -122,6 +122,11 @@ extern "C" int throw_exception() {
                               Triple.getArch() == llvm::Triple::aarch64_32))
     GTEST_SKIP();
 
+  // FIXME: RISC-V fails as .eh_frame handling is not yet implemented in
+  // JITLink for RISC-V. See PR #66067.
+  if (Triple.isRISCV())
+    GTEST_SKIP();
+
   llvm::cantFail(Interp->ParseAndExecute(ExceptionCode));
   testing::internal::CaptureStdout();
   auto ThrowException =

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asb asb merged commit ca003ee into llvm:main Oct 4, 2023
4 checks passed
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Oct 12, 2023
Local branch amd-gfx a86283a Merged main:e00f2272d640 into amd-gfx:7a55dcafa40e
Remote branch main ca003ee [clang-repl] Disable InterpreterExceptionTest on RISC-V (llvm#68216)
hahnjo added a commit to hahnjo/llvm-project that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants