Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFS][CodeMoverUtils] Add comment saying not ready for production usage. #68573

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

dtemirbulatov
Copy link
Contributor

Add comment to CodeMoverUtils.h

@llvmbot
Copy link
Collaborator

llvmbot commented Oct 9, 2023

@llvm/pr-subscribers-llvm-transforms

Changes

Add comment to CodeMoverUtils.h


Full diff: https://github.com/llvm/llvm-project/pull/68573.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Transforms/Utils/CodeMoverUtils.h (+3)
diff --git a/llvm/include/llvm/Transforms/Utils/CodeMoverUtils.h b/llvm/include/llvm/Transforms/Utils/CodeMoverUtils.h
index 0f32a97f9fccff4..4fd147a1f7b3b9f 100644
--- a/llvm/include/llvm/Transforms/Utils/CodeMoverUtils.h
+++ b/llvm/include/llvm/Transforms/Utils/CodeMoverUtils.h
@@ -9,6 +9,9 @@
 // This family of functions determine movements are safe on basic blocks, and
 // instructions contained within a function.
 //
+// Please note that this is work in progress, and the functionality is not
+// ready for broader production use.
+//
 //===----------------------------------------------------------------------===//
 
 #ifndef LLVM_TRANSFORMS_UTILS_CODEMOVERUTILS_H

Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches my understanding. Would need from-scratch re-review to be approved for production use.

@dtemirbulatov dtemirbulatov merged commit 6afbc09 into llvm:main Oct 9, 2023
4 checks passed
@dtemirbulatov dtemirbulatov deleted the codemoverutils-comment branch October 9, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants