-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PowerPC][JITLink] Support R_PPC64_GOT_TLSGD_PCREL34 #68660
Conversation
Since we don't have pwr10 buildbot, I don't add test in #include <stdio.h>
#include <iostream>
#include <thread>
#include <vector>
_Thread_local int id;
int main() {
std::vector<std::thread> vt;
for (int i = 0; i < 8; ++i) {
vt.emplace_back([&]() {
std::cout << &id << std::endl;
});
}
for (auto &t : vt) t.join();
return 0;
}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and our use case in cms-sw/cmssw#41658. I'd wait for one more reviewer to approve it. @lhames ping.
Are you able to add a testcase that runs locally? If so then I think it make sense to include one even if there's no builedbot to run it, since at least PPC developers could run it locally. LGTM though -- if you're not able to add a testcase please go ahead and land anyway. |
036ca30
to
c2f565a
Compare
Added TLS test for pwr10. Since requiring different PLT stubs for the same external symbol is rare(need |
Thanks very much for adding the testcase! |
R_PPC64_GOT_TLSGD_PCREL34
is generated for pwr10+.