[MachineBasicBlock] Fix use after free in SplitCriticalEdge #68786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove use after free when attempting to update SlotIndexes in MachineBasicBlock::SplitCriticalEdge. Add delegate mechanism for MachineBasicBlock to observe instructions added or removed when calling target specific functions for updating branches and update SlotIndexes appropriately.
jayfoad
reviewed
Oct 11, 2023
- Use MachineFunction delegate instead
jayfoad
reviewed
Oct 12, 2023
| @@ -14,6 +14,7 @@ | |||
| #define LLVM_CODEGEN_MACHINEBASICBLOCK_H | |||
|
|
|||
| #include "llvm/ADT/GraphTraits.h" | |||
| #include "llvm/ADT/SmallPtrSet.h" | |||
jayfoad
reviewed
Oct 12, 2023
jayfoad
reviewed
Oct 12, 2023
jayfoad
approved these changes
Oct 12, 2023
- Remove unnecessary include - Change MBB pointer to MF reference - Rename Delegate - Tidy constructor parameter names
jayfoad
approved these changes
Oct 13, 2023
Exactly! Thanks for the fix! |
perlfu
added a commit
to perlfu/llvm-project
that referenced
this pull request
Oct 18, 2023
Follow up fix for llvm#68786 to address that MachineFunction handleInsertion is actually called before a new instruction has been inserted into the block. Hence new instructions must be recorded and SlotIndex updates performed after the delegate call.
perlfu
added a commit
that referenced
this pull request
Oct 21, 2023
Follow up fix for #68786 to address that MachineFunction handleInsertion is actually called before a new instruction has been inserted into the block. Hence new instructions must be recorded and SlotIndex updates performed after the delegate call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use after free when attempting to update SlotIndexes in MachineBasicBlock::SplitCriticalEdge.
Add delegate mechanism for MachineBasicBlock to observe instructions added or removed when calling target specific functions for updating branches and update SlotIndexes appropriately.