Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++] Move the check-generated-files job to Github Actions #68920

Merged
merged 5 commits into from
Oct 19, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/libcxx-check-generated-files.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: "Check libc++ generated files"
on:
pull_request:
paths:
- 'libcxx/**'

jobs:
check_generated_files:
runs-on: ubuntu-latest
steps:
- name: Fetch LLVM sources
uses: actions/checkout@v4
with:
ldionne marked this conversation as resolved.
Show resolved Hide resolved
fetch-depth: 2

- name: Install clang-format
uses: aminya/setup-cpp@v1
with:
clangformat: 17.0.1

- name: Install Ninja
ldionne marked this conversation as resolved.
Show resolved Hide resolved
run: sudo apt-get install -y ninja-build

- name: Check generated files
run: libcxx/utils/ci/run-buildbot check-generated-output
ldionne marked this conversation as resolved.
Show resolved Hide resolved
19 changes: 0 additions & 19 deletions libcxx/utils/ci/buildkite-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,31 +26,12 @@ env:
# LLVM POST-BRANCH bump version
# LLVM POST-BRANCH add compiler test for ToT - 1, e.g. "Clang 17"
# LLVM RELEASE bump remove compiler ToT - 3, e.g. "Clang 15"
LLVM_STABLE_VERSION: "17" # Used for tooling, update after the RELEASE.
LLVM_HEAD_VERSION: "18" # Used compiler, update POST-BRANCH.
GCC_STABLE_VERSION: "13"
steps:
#
# Light pre-commit tests for things like forgetting to update generated files.
#
- label: "Generated output"
command: "libcxx/utils/ci/run-buildbot check-generated-output"
artifact_paths:
- "**/generated_output.patch"
- "**/generated_output.status"
env:
CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}"
CLANG_FORMAT: "/usr/bin/clang-format-${LLVM_STABLE_VERSION}"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Documentation"
command: "libcxx/utils/ci/run-buildbot documentation"
artifact_paths:
Expand Down