Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libclang/python] Add missing concept declaration CursorKind #69125

Merged
merged 1 commit into from Oct 25, 2023

Conversation

VelocityRa
Copy link
Contributor

@VelocityRa VelocityRa commented Oct 15, 2023

Maps to CXCursor_ConceptDecl, added in ee85240.

Without this I get this error on my codebase which uses C++20 concept decls:

ValueError: Unknown template argument kind 604

Maps to `CXCursor_ConceptDecl`, added in ee85240.
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Oct 15, 2023
@VelocityRa
Copy link
Contributor Author

Pinging @mdfazlay and @AaronBallman for review (sorry if I chose the wrong people!)

Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay on review, but the changes here LGTM!

@AaronBallman AaronBallman merged commit 8b32289 into llvm:main Oct 25, 2023
4 checks passed
@llvmbot
Copy link
Collaborator

llvmbot commented Oct 25, 2023

@llvm/pr-subscribers-clang

Author: Nick Renieris (VelocityRa)

Changes

Maps to CXCursor_ConceptDecl, added in ee85240.

Without this I get this error on my codebase which uses C++20 concept decls:

ValueError: Unknown template argument kind 604

Full diff: https://github.com/llvm/llvm-project/pull/69125.diff

1 Files Affected:

  • (modified) clang/bindings/python/clang/cindex.py (+2)
diff --git a/clang/bindings/python/clang/cindex.py b/clang/bindings/python/clang/cindex.py
index ff386d2094a0b88..6a16f3a9ef6e957 100644
--- a/clang/bindings/python/clang/cindex.py
+++ b/clang/bindings/python/clang/cindex.py
@@ -1403,6 +1403,8 @@ def __repr__(self):
 CursorKind.STATIC_ASSERT = CursorKind(602)
 # A friend declaration
 CursorKind.FRIEND_DECL = CursorKind(603)
+# A concept declaration
+CursorKind.CONCEPT_DECL = CursorKind(604)
 
 # A code completion overload candidate.
 CursorKind.OVERLOAD_CANDIDATE = CursorKind(700)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants