Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSan] Mark create_thread_leak.cpp as UNSUPPORTED: darwin. #69187

Closed
wants to merge 1 commit into from

Conversation

hnrklssn
Copy link
Member

@hnrklssn hnrklssn commented Oct 16, 2023

This test failed in https://green.lab.llvm.org/green/job/clang-stage1-RA-release-17.x/63/ but not in https://green.lab.llvm.org/green/job/clang-stage1-RA-release-17.x/64/, which uses the same checkout of the LLVM repo. The only difference is llvm/llvm-zorg@0344f45 which is an llvm-zorg commit and doesn’t seem related. Cherry-picking this to prevent flaky test failures on the release branch:

It started to fail in a flaky manner a few days ago on GreenDragon buildbots
(i.e. x86_64-darwin). I didn't track down the root cause but LSan isn't actually
supported on darwin anyway, so UNSUPPORTED seems appropriate.

Prior art: 3ff080b5.

(cherry picked from commit 0a3519d5a27b9400250b5f6656b50148021e7496)

It started to fail in a flaky manner a few days ago on GreenDragon buildbots
(i.e. x86_64-darwin). I didn't track down the root cause but LSan isn't
actually supported on darwin anyway, so UNSUPPORTED seems appropriate.

Prior art: 3ff080b.

(cherry picked from commit 0a3519d)
@github-actions
Copy link

This repository does not accept pull requests. Please follow http://llvm.org/docs/Contributing.html#how-to-submit-a-patch for contribution to LLVM.

@github-actions github-actions bot closed this Oct 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
@tru
Copy link
Collaborator

tru commented Oct 16, 2023

This was closed because the release repo still contains the workflow that closes PR's automatically. Generally we still use the issue comment cherry-pick way to open these PRs for the release branch, but it's fine and I have reopened it.

@tru tru reopened this Oct 16, 2023
@tru
Copy link
Collaborator

tru commented Oct 16, 2023

Ah on other thoughts, it's probably better you use the cherry-pick comment flow, because this will be closed again if you push any updates.

@tru tru closed this Oct 16, 2023
@hnrklssn
Copy link
Member Author

Ah, I see! I wasn't aware of the magic comments. I'll give them a try.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants