[TableGen][NFC] Remove MultiClass argument and Scoper in QualifyName #69297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MultiClass argument is not used any more since aa84326. Besides, for maintainability, we should put the implementation of qualifying name in one place (that is `QualifyName` function), so `Scoper` is removed and we use `IsMC` to indicate that we are in a multiclass.
wangpc-pp
requested review from
River707,
arsenm,
Paul-C-Anagnostopoulos,
nhaehnle and
fpetrogalli
…fyName Add overloaded QualifyName for MultiClass
nhaehnle
approved these changes
Oct 23, 2023
|
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Oct 26, 2023
Local branch amd-gfx 0f5dcae Merged main:86bb713142c3 into amd-gfx:fd6ee38e1eb7 Remote branch main 1e43975 [TableGen][NFC] Remove MultiClass argument and Scoper in QualifyName (llvm#69297)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiClass argument is not used any more since aa84326.
Besides, for maintainability, we should put the implementation of
qualifying name in one place (that is
QualifyNamefunction), soScoperis removed and we useIsMCto indicate that we are in amulticlass.