[LICM]The store instruction is prevented from #69413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
XingYuShuai
force-pushed
the
fix-signal-before-loop
branch
2 times, most recently
from
87fd576
to
3aee316
Compare
nikic
requested changes
Oct 18, 2023
being mentioned outside the loop in some cases. Please refer to issue:68776 for details. Fixes llvm#68776 Fixes llvm#69279
XingYuShuai
force-pushed
the
fix-signal-before-loop
branch
from
3aee316
to
e6774fe
Compare
When Run_Index is atomic, there is no problem with open source version. For details about the test cases and results, see：#68776 (comment) And I also added my patch and retested the above test cases to keep consistent with the original version. Does that explain your problem? If you still have a problem, can you describe your problem in more detail? For example, in the test-code2.txt test case I provided, which variable is atomic? Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The store instruction is prevented from being mentioned outside the loop in some cases.
Please refer to issue:68776 for details.
Fixes #68776
Fixes #69279