Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules #69431

Merged
merged 1 commit into from
Oct 23, 2023

Commits on Oct 23, 2023

  1. [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by…

    … default on windows after c++20
    
    There are already 3 issues about the broken state of
    -fdelayed-template-parsing and C++20 modules:
    - llvm#61068
    - llvm#64810
    - llvm#65027
    
    The problem is more complex than I thought. I am not sure how to fix it
    properly now. Given the complexities and -fdelayed-template-parsing is
    actually an extension to support old MS codes, I think it may make sense
    to not enable the -fdelayed-template-parsing option by default with
    C++20 modules to give more user friendly experience. Users who still want
    -fdelayed-template-parsing can specify it explicitly.
    
    Given the discussion in llvm#69551,
    we decide to not enable -fdelayed-template-parsing by default on windows
    after c++20
    ChuanqiXu9 committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    9c0d81e View commit details
    Browse the repository at this point in the history