[clang] Bail out if the result of function template instantiation is not a function. #69449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
sam-mccall
approved these changes
Oct 18, 2023
| @@ -2649,7 +2649,9 @@ TypeSourceInfo *Sema::SubstFunctionDeclType(TypeSourceInfo *T, | |||
| } else { | |||
| Result = Instantiator.TransformType(TLB, TL); | |||
| } | |||
| if (Result.isNull()) | |||
| // When clang goes into recovery mode, it might substitute | |||
There was a problem hiding this comment.
Not sure "recovery mode" is well-defined enough to refer to in this way
maybe:
When there are errors resolving types, clang may use IntTy as a fallback, breaking our assumption that function declarations have function types.
(I thought there was a name for this usage of IntTy but I can't find one. It happens e.g. at GetFullTypeForDeclarator, SemaType.cpp:5734)
| template <typename T> | ||
| void Func() { | ||
| using MyType = Type<T>(); // expected-note{{in instantiation of template type alias 'Type' requested here}} | ||
| MyType var; |
There was a problem hiding this comment.
// This is a function declaration, not a variable declaration!
// After substitution, we do not have a valid function type, and used to crash.
|
Pre-empted by #69459. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.