Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static and avoid useless copies in their arguments #69463

Closed
wants to merge 3 commits into from
Closed

[NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static and avoid useless copies in their arguments #69463

wants to merge 3 commits into from

Conversation

jmmartinez
Copy link

@jmmartinez jmmartinez commented Oct 18, 2023 •
edited

  • Remove unused variable
  • Take read-only arguments by read-only reference
  • Both functions are not used outside CommonArgs.cpp, make them static

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Oct 18, 2023
@jmmartinez jmmartinez changed the title [NFC] Remove unused variable "AOBFileNames" [NFC][Clang] GetSDLFromOffloadArchive and SDLSearch Oct 19, 2023
@jmmartinez jmmartinez changed the title [NFC][Clang] GetSDLFromOffloadArchive and SDLSearch [NFC][Clang] Make GetSDLFromOffloadArchive and SDLSearch static and avoid useless copies in their arguments Oct 19, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited

✅ With the latest revision this PR passed the C/C++ code formatter.

[NFC][Clang] Make read-only arguments of GetSDLFromOffloadArchive and…
7472c05 
… SDLSearch read-only references instead of copying them
@jmmartinez jmmartinez closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmmartinez @llvmbot