Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang-tidy] Ignore deleted functions in cppcoreguidelines-rvalue-reference-param-not-moved #69514

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -62,23 +62,28 @@ void RvalueReferenceParamNotMovedCheck::registerMatchers(MatchFinder *Finder) {
anyOf(isConstQualified(), substTemplateTypeParmType()))))),
optionally(hasType(qualType(references(templateTypeParmType(
hasDeclaration(templateTypeParmDecl().bind("template-type"))))))),
anyOf(hasAncestor(cxxConstructorDecl(
ToParam, isDefinition(), unless(isMoveConstructor()),
optionally(hasDescendant(MoveCallMatcher)))),
hasAncestor(functionDecl(
unless(cxxConstructorDecl()), ToParam,
unless(cxxMethodDecl(isMoveAssignmentOperator())),
hasBody(optionally(hasDescendant(MoveCallMatcher))))))),
hasDeclContext(
functionDecl(
isDefinition(), unless(isDeleted()), unless(isDefaulted()),
unless(cxxConstructorDecl(isMoveConstructor())),
unless(cxxMethodDecl(isMoveAssignmentOperator())), ToParam,
anyOf(cxxConstructorDecl(
optionally(hasDescendant(MoveCallMatcher))),
functionDecl(unless(cxxConstructorDecl()),
optionally(hasBody(
hasDescendant(MoveCallMatcher))))))
.bind("func"))),
this);
}

void RvalueReferenceParamNotMovedCheck::check(
const MatchFinder::MatchResult &Result) {
const auto *Param = Result.Nodes.getNodeAs<ParmVarDecl>("param");
const auto *Function = Result.Nodes.getNodeAs<FunctionDecl>("func");
const auto *TemplateType =
Result.Nodes.getNodeAs<TemplateTypeParmDecl>("template-type");

if (!Param)
if (!Param || !Function)
return;

if (IgnoreUnnamedParams && Param->getName().empty())
Expand All @@ -87,10 +92,6 @@ void RvalueReferenceParamNotMovedCheck::check(
if (!Param->isUsed() && Param->hasAttr<UnusedAttr>())
return;

const auto *Function = dyn_cast<FunctionDecl>(Param->getDeclContext());
if (!Function)
return;

if (IgnoreNonDeducedTemplateTypes && TemplateType)
return;

Expand Down
3 changes: 2 additions & 1 deletion clang-tools-extra/docs/ReleaseNotes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,8 @@ Changes in existing checks

- Improved :doc:`cppcoreguidelines-rvalue-reference-param-not-moved
<clang-tidy/checks/cppcoreguidelines/rvalue-reference-param-not-moved>` check
to ignore unused parameters when they are marked as unused.
to ignore unused parameters when they are marked as unused and parameters of
deleted functions and constructors.

- Improved :doc:`llvm-namespace-comment
<clang-tidy/checks/llvm/namespace-comment>` check to provide fixes for
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -334,8 +334,7 @@ void instantiate_a_class_template() {
withObjRef.never_moves(o);
}

namespace gh68209
{
namespace gh68209 {
void f1([[maybe_unused]] int&& x) {}

void f2(__attribute__((unused)) int&& x) {}
Expand All @@ -358,3 +357,13 @@ namespace gh68209
void f8(__attribute__((unused)) int&& x) { x += 1; }
// CHECK-MESSAGES: :[[@LINE-1]]:41: warning: rvalue reference parameter 'x' is never moved from inside the function body [cppcoreguidelines-rvalue-reference-param-not-moved]
} // namespace gh68209

namespace gh69412 {
struct S
{
S(const int&);
S(int&&) = delete;

void foo(int&&) = delete;
};
} // namespace gh69412