[AMDGPU] Generic lowering for rint and nearbyint #69596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
backend:AMDGPU
backend:X86
llvm:globalisel
llvm:SelectionDAG
|
Continuation of: https://reviews.llvm.org/D159271 |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Acim-Maravic
force-pushed
the
froundeven
branch
from
d55d892
to
daebb28
Compare
arsenm
requested changes
Oct 24, 2023
| @@ -1888,6 +1888,14 @@ class MachineIRBuilder { | |||
| return buildInstr(TargetOpcode::G_FRINT, {Dst}, {Src0}, Flags); | |||
| } | |||
|
|
|||
| /// Build and insert \p Dst = G_INTRINSIC_ROUNDEVEN \p Src0, \p Src1 | |||
| MachineInstrBuilder | |||
| buildintrinsicRoundeven(const DstOp &Dst, const SrcOp &Src0, | |||
There was a problem hiding this comment.
Capitalization is off. I'd also probably just drop the intrinsic part from the name (we should also drop it from the opcode name)
Acim-Maravic
force-pushed
the
froundeven
branch
from
daebb28
to
0b2b684
Compare
arsenm
approved these changes
Nov 8, 2023
Acim-Maravic
force-pushed
the
froundeven
branch
4 times, most recently
from
0ec3761
to
213dbcc
Compare
There are three different rounding intrinsics, that are brought down to same instruction.
Acim-Maravic
force-pushed
the
froundeven
branch
from
213dbcc
to
a0c3eb8
Compare
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Nov 20, 2023
The are three different rounding intrinsics, that are brought down to same instruction. Co-authored-by: Acim Maravic <acim.maravic@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The are three different rounding intrinsics, that are brought down to same instruction.