Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAG] Fold (mul (sext (add_nsw x, c1)), c2) -> (add (mul (sext x), c2), c1*c2) #69667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DAG] Fold (mul (sext (add_nsw x, c1)), c2) -> (add (mul (sext x), c2), c1*c2) #69667

wants to merge 1 commit into from

Conversation

LiqinWeng
Copy link
Contributor

No description provided.

@llvmbot llvmbot added the llvm:SelectionDAG SelectionDAGISel as well label Oct 20, 2023
@LiqinWeng LiqinWeng mentioned this pull request Oct 20, 2023
Merged
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited

✅ With the latest revision this PR passed the C/C++ code formatter.

@topperc
Copy link
Collaborator

topperc commented Oct 20, 2023 •
edited

I think maybe we should implement RISCVTTIImpl::shouldConsiderAddressTypePromotion for RISC-V. Which enables CodeGenPrepare to do some address optimizations. I have a patch for that in my downstream I can try to extract.

@LiqinWeng
Copy link
Contributor Author

I think maybe we should implement RISCVTTIImpl::shouldConsiderAddressTypePromotion for RISC-V. Which enables CodeGenPrepare to do some address optimizations. I have a patch for that in my downstream I can try to extract.

OK， I will abandon this patch

@LiqinWeng
Copy link
Contributor Author

I think maybe we should implement RISCVTTIImpl::shouldConsiderAddressTypePromotion for RISC-V. Which enables CodeGenPrepare to do some address optimizations. I have a patch for that in my downstream I can try to extract.

Hi， Is this currently implemented? @topperc

@kiranchandramohan kiranchandramohan mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldsteinn goldsteinn Awaiting requested review from goldsteinn

Assignees
No one assigned
Labels
backend:X86 llvm:SelectionDAG SelectionDAGISel as well
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LiqinWeng @topperc @llvmbot