Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlir][transform] Handle multiple library preloading passes. #69705

Merged
merged 6 commits into from
Oct 25, 2023
Merged

[mlir][transform] Handle multiple library preloading passes. #69705

merged 6 commits into from
Oct 25, 2023

Commits on Oct 25, 2023

  1. Move module merging utils to dialect target. (NFC) 

    This is a preparatory commit for fixing the handling of multiple
transform library modules. The plan is to merge every newly loaded
module into the global library module rather than keeping around a list.
Since that merging happens in the dialect and depends on the dialect,
the two depend on each other and thus have to live in the same CMake
target.
    @ingomueller-net
    ingomueller-net committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b6a9868 View commit details
    Browse the repository at this point in the history

  2. Fix some unrelated issues found by @ftynse.

    @ingomueller-net
    ingomueller-net committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    d2fa236 View commit details
    Browse the repository at this point in the history

  3. [mlir][transform] Handle multiple library preloading passes. 

    The transform dialect stores a "library module" that the preload pass
can populate. Until now, each pass registered an additional module by
simply pushing it to a vector; however, the interpreter only used the
first of them. This commit turns the registration into "loading", i.e.,
each newly added module gets merged into the existing one. This allows
the loading to be split into several passes, and using the library in
the interpreter now takes all of them into account. While this design
avoids repeated merging every time the library is accessed, it requires
that the implementation of merging modules lives in the
`TransformDialect` target (since it at the dialect depend on each
other).

This resolves llvm#69111.
    @ingomueller-net
    ingomueller-net committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    822d127 View commit details
    Browse the repository at this point in the history

  4. Fix issue found by @ftynse. Also make init function private.

    @ingomueller-net
    ingomueller-net committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    5c7302a View commit details
    Browse the repository at this point in the history

  5. Revert one of the "unrelated fixes". 

    That fix had removed the test in `parseTransformModuleFromFile` for an
empty file name. However, the function is still used in cases where the
file name may be empty, in which case we do not want a failure but want
to return from the function.
    @ingomueller-net
    ingomueller-net committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8fda307 View commit details
    Browse the repository at this point in the history

  6. Fix test that broke after rebasing on top of llvm#69329.

    @ingomueller-net
    ingomueller-net committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    911eb7c View commit details
    Browse the repository at this point in the history