Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DFP IR type. #69718

Closed
wants to merge 4 commits into from
Closed

Add support for DFP IR type. #69718

wants to merge 4 commits into from

Conversation

zahiraam
Copy link
Contributor

@zahiraam zahiraam commented Oct 20, 2023 •
edited

Add decimal32, decimal64 and decimal128 IR types.
Still to be done:
APFloat
Constant Folding

andykaylor
andykaylor reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@andykaylor andykaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right. I've got a bunch of minor comments, but only a couple of things of any significance.

llvm/docs/BitCodeFormat.rst Outdated Show resolved Hide resolved
llvm/docs/LangRef.rst Show resolved Hide resolved
llvm/include/llvm/IR/IRBuilder.h Outdated Show resolved Hide resolved
llvm/include/llvm/IR/Type.h Show resolved Hide resolved
llvm/lib/AsmParser/LLLexer.cpp Outdated Show resolved Hide resolved
llvm/lib/Bitcode/Writer/BitcodeWriter.cpp Outdated Show resolved Hide resolved
llvm/lib/IR/AsmWriter.cpp Outdated Show resolved Hide resolved
llvm/lib/IR/LLVMContextImpl.h Outdated Show resolved Hide resolved
llvm/lib/IR/Type.cpp Outdated Show resolved Hide resolved
llvm/lib/IR/Type.cpp Outdated Show resolved Hide resolved
@zahiraam
Copy link
Contributor Author

Does anyone know what is the Test Documentation build fail? I haven't seen this before.

@tahonermann
Copy link
Contributor

Hi, Zahira. We haven't been pushing DFP changes to upstream yet. Could you submit a PR to the dfp branch of my fork instead?

@zahiraam
Copy link
Contributor Author

Hi, Zahira. We haven't been pushing DFP changes to upstream yet. Could you submit a PR to the dfp branch of my fork instead?

hmm! I thought that's what I had done!

@boomanaiden154
Copy link
Contributor

Was trying to pull this branch into my fork to debug a CI failure for the documentation build and annoyingly git push works on other people's forks when a PR is open. Things should be back to their original state, but I had to force push. Sorry about that. I'll remember to be more careful next time.

@zahiraam zahiraam closed this Oct 24, 2023
@zahiraam zahiraam deleted the IRTypes branch October 24, 2023 18:45
@zahiraam zahiraam restored the IRTypes branch October 24, 2023 18:53
@zahiraam zahiraam reopened this Oct 24, 2023
@zahiraam zahiraam closed this Oct 24, 2023
@zahiraam zahiraam deleted the IRTypes branch October 24, 2023 21:27
@zahiraam zahiraam mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tahonermann tahonermann Awaiting requested review from tahonermann

@shafik shafik Awaiting requested review from shafik

@andykaylor andykaylor Awaiting requested review from andykaylor

@nikic nikic Awaiting requested review from nikic nikic will be requested when the pull request is marked ready for review nikic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zahiraam @tahonermann @boomanaiden154 @andykaylor