[Kaleidoscope] LLVM is not needed for chapter two #69823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm-beanz
approved these changes
Nov 8, 2023
|
Adding commiters to doc/tutorial since LLVM 17 to get this merged: |
|
Hey, anything required from my side? |
MaskRay
approved these changes
Jan 13, 2024
MaskRay
changed the title
No, @MaskRay was kind enough to merge this PR. I was just pinging all recent committers of this directory to get this merged. |
|
Thanks, @MaskRay. |
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
Since the example (llvm/examples/Kaleidoscope/Chapter2/toy.cpp) is self-contained there is no need to use LLVM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the example (llvm/examples/Kaleidoscope/Chapter2/toy.cpp) is self-contained there is no need to use LLVM.