Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMDGPU] Improve isBasicBlockPrologue helper function #69924

Merged
merged 1 commit into from
Oct 27, 2023

Commits on Oct 27, 2023

  1. [AMDGPU] Try to fix the block prologs broken by RA inserted instructions

    The insertion point determined by RA while attempting spills and liverange
    split at the beginning of a block goes wrong at times, and the newly
    inserted vector instructions are placed before the exec-mask restore
    instruction which is wrong. It occurs mainly due to the dependency on
    isBasicBlockPrologue that doesn't account early inserted instructions
    (spills and splits) during RA and causes the block prolog break.
    
    A better approach for deciding the insertion point should be worked out.
    For now, improving the helper function to consider all possible early
    insertions. This patch includes the spill instructions. The copies
    associated with liverange split should also be included in the block
    prolog.
    cdevadas committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    ffba940 View commit details
    Browse the repository at this point in the history