Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flang] Allow lowering of sub-expressions to be overridden #69944

Merged
merged 2 commits into from
Oct 25, 2023
Merged

[flang] Allow lowering of sub-expressions to be overridden #69944

merged 2 commits into from
Oct 25, 2023

Commits on Oct 24, 2023

  1. [flang] Allow lowering of sub-expressions to be overridden 

    OpenACC/OpenMP atomic lowering needs a finer control over expression
lowering. This patch allows mapping evaluate::Expr<T> to mlir::Value
so that any subsequent expression lowering will use these values when
an operand is a mapped Expr<T>.

This is an alternative to llvm#69866
From which I took the test.

The same test as in llvm#69866 are
failing because the "non atomic part" is now out of the atomic.update
op, which in some case causing verification failure because this is
generated in the middle of an omp.atomic.capture. I did not try fixing
these failures. My patch is about the lowering infrastructure and how to
use it rather than the OpenMP semantics.

Co-authored-by: Nimish Mishra <neelam.nimish@gmail.com>
    @jeanPerier @NimishMishra
    jeanPerier and NimishMishra committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1bfbe4c View commit details
    Browse the repository at this point in the history

  2. Generate non atomic expr before atomic.capture and fix tests

    @jeanPerier
    jeanPerier committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3f2f95d View commit details
    Browse the repository at this point in the history