Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMDGPU] Set SchedRW = Write64Bit on V_MOV_B64 #70135

Merged
merged 1 commit into from Oct 25, 2023

Conversation

rampitec
Copy link
Collaborator

This is mostly NFCI as V_MOV_B64_PSEUDO is selected instead and expanded past RA.

This is mostly NFCI as V_MOV_B64_PSEUDO is selected instead and
expanded past RA.
@llvmbot
Copy link
Collaborator

llvmbot commented Oct 24, 2023

@llvm/pr-subscribers-backend-amdgpu

Author: Stanislav Mekhanoshin (rampitec)

Changes

This is mostly NFCI as V_MOV_B64_PSEUDO is selected instead and expanded past RA.


Full diff: https://github.com/llvm/llvm-project/pull/70135.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/VOP1Instructions.td (+1-1)
diff --git a/llvm/lib/Target/AMDGPU/VOP1Instructions.td b/llvm/lib/Target/AMDGPU/VOP1Instructions.td
index 734db326fb77ddd..9c19091e3d583f1 100644
--- a/llvm/lib/Target/AMDGPU/VOP1Instructions.td
+++ b/llvm/lib/Target/AMDGPU/VOP1Instructions.td
@@ -221,7 +221,7 @@ def VOPProfile_MOV : VOPProfile <[i32, i32, untyped, untyped]> {
 let isReMaterializable = 1, isAsCheapAsAMove = 1 in {
 defm V_MOV_B32 : VOP1Inst <"v_mov_b32", VOPProfile_MOV, null_frag, 0x8>;
 
-let SubtargetPredicate = isGFX940Plus in
+let SubtargetPredicate = isGFX940Plus, SchedRW = [Write64Bit] in
 defm V_MOV_B64 : VOP1Inst <"v_mov_b64", VOP_I64_I64>;
 } // End isMoveImm = 1
 

@rampitec rampitec changed the title [AMDGPU] Set Write64Bit = Write64Bit on V_MOV_B64 [AMDGPU] Set SchedRW = Write64Bit on V_MOV_B64 Oct 25, 2023
Copy link
Contributor

@jayfoad jayfoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@rampitec rampitec merged commit 8715600 into llvm:main Oct 25, 2023
4 checks passed
@rampitec rampitec deleted the schedrw-v-mov-b64 branch October 25, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants