[BOLT] Modify MCPlus annotation internals. NFCI. #70412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When annotating MCInst instructions, attach extra annotation operands directly to the annotated instruction, instead of attaching them to an instruction pointed to by a special kInst operand. With this change, it's no longer necessary to allocate MCInst and most of the first-class annotations come with free memory as currently MCInst is declared with: SmallVector<MCOperand, 10> Operands; i.e. more operands than are normally being used. We still create a kInst operand with a nullptr instruction value to designate the beginning of annotation operands. However, this special operand might not be needed if we can rely on MCInstrDesc::NumOperands.
|
Nice @maksfb Thank you! It shall speed up golang processing time significantly (probably lowering memory consumption too), shall try it when we would have a free time :) |
mtvec
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
LGTM in general, just two remarks:
- There is some duplication of logic between
getNumPrimeOperandsandgetAnnotationInstOp(searching forkInst). Maybe one could be written in function of the other? - Since we don't need any
MCPlusBuilderstate anymore for annotations, should we move all the annotation-related functions toMCPlus? Not saying that should happen in this PR (the diff is probably fairly large) but it seems to be the more logical place for this functionality.
|
One more remark: I think |
getNumPrimeOperands() is a bit more optimized. It can return before finding the
We still use |
Thanks. I'll add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When annotating MCInst instructions, attach extra annotation operands directly to the annotated instruction, instead of attaching them to an instruction pointed to by a special kInst operand.
With this change, it's no longer necessary to allocate MCInst and most of the first-class annotations come with free memory as currently MCInst is declared with:
i.e. more operands than are normally being used.
We still create a kInst operand with a nullptr instruction value to designate the beginning of annotation operands. However, this special operand might not be needed if we can rely on MCInstrDesc::NumOperands.