New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libcxx] Amend XFAIL for failing tests on Windows #70422
Conversation
@llvm/pr-subscribers-libcxx Author: Petr Hosek (petrhosek) ChangesSome tests starting passing/failing after #69431 because Clang no longer enables -fdelayed-template-parsing by default on Windows with C++20 modules. Full diff: https://github.com/llvm/llvm-project/pull/70422.diff 4 Files Affected:
diff --git a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
index a6c1160c7022f07..45c3f81fffd3d44 100644
--- a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
+++ b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
@@ -8,7 +8,7 @@
// This test fails because diagnose_if doesn't emit all of the diagnostics
// when -fdelayed-template-parsing is enabled, like it is in MSVC mode.
-// XFAIL: msvc
+// XFAIL: msvc && (clang-16 || clang-17)
// REQUIRES: diagnose-if-support
diff --git a/libcxx/test/libcxx/fuzzing/random.pass.cpp b/libcxx/test/libcxx/fuzzing/random.pass.cpp
index 79ab7ac41151c97..21b7c9348c07821 100644
--- a/libcxx/test/libcxx/fuzzing/random.pass.cpp
+++ b/libcxx/test/libcxx/fuzzing/random.pass.cpp
@@ -6,6 +6,11 @@
//
//===----------------------------------------------------------------------===//
+// This test fails with because Clang no longer enables
+// -fdelayed-template-parsing by default on Windows with C++20 modules
+// (#69431).
+// XFAIL: msvc && clang-18
+
// UNSUPPORTED: c++03, c++11
#include <cassert>
diff --git a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
index 87767a2ee4311cb..eaa8b1ac44c7471 100644
--- a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
+++ b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
@@ -6,6 +6,11 @@
//
//===----------------------------------------------------------------------===//
+// This test fails with because Clang no longer enables
+// -fdelayed-template-parsing by default on Windows with C++20 modules (#69431).
+
+// XFAIL: msvc && clang-18
+
// <math.h>
#include <math.h>
diff --git a/libcxx/test/std/numerics/c.math/cmath.pass.cpp b/libcxx/test/std/numerics/c.math/cmath.pass.cpp
index 11a3de748cb7a69..ab7c759dcb438b2 100644
--- a/libcxx/test/std/numerics/c.math/cmath.pass.cpp
+++ b/libcxx/test/std/numerics/c.math/cmath.pass.cpp
@@ -6,6 +6,10 @@
//
//===----------------------------------------------------------------------===//
+// This test fails with because Clang no longer enables
+// -fdelayed-template-parsing by default on Windows with C++20 modules (#69431).
+// XFAIL: msvc && clang-18
+
// <cmath>
#include <cmath>
|
8ad0461
to
e5af032
Compare
Sorry for confusing. Actually that PR don't enable -fdelayed-template-parsing by default on Windows with C++20. It is not related to modules. I change the title in the commit messages: 366ffba too. But it looks like the github PR doesn't update automatically. |
e5af032
to
fdfdaa9
Compare
libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
Outdated
Show resolved
Hide resolved
fdfdaa9
to
2476e6c
Compare
2476e6c
to
202fb47
Compare
Some tests starting passing/failing after llvm#69431 because Clang no longer enables -fdelayed-template-parsing by default on Windows with C++20.
202fb47
to
6d3ffcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, we had some dealings with an ABI break, then the week-end happened, etc. Thanks for fixing.
Some tests starting passing/failing after #69431 because Clang no longer enables -fdelayed-template-parsing by default on Windows with C++20.