Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Driver] Handle Flang in same manner between Gnu and *BSD/Solaris ToolChain #70429

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Oct 27, 2023

No description provided.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Oct 27, 2023
@banach-space
Copy link
Contributor

@brad0 Thanks for sending this - could you provide some context in the summary? Why update the GNU Toolchain rather than *BSD - as in, what should be source of truth here? Also, could you add tests?

I will be OK next week, but am happy for this to be merged once my comments are addressed and @MaskRay is also happy with this. Thanks!

@MaskRay
Copy link
Member

MaskRay commented Oct 28, 2023

Seems fine to me once a test is added:)

@brad0
Copy link
Contributor Author

brad0 commented Nov 14, 2023

Seems fine to me once a test is added:)

I cannot test as is as the frontend does not support these flags yet. I am just keeping things in sync between the C++ bit above that..

  if (D.CCCIsCXX() &&
      !Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs,
                   options::OPT_r)) {

and the behavior being the same for the other OS's.

But I am working on a patch for the frontend to enable the flags. So I'll just keep this around for a bit and then update it.

@brad0
Copy link
Contributor Author

brad0 commented Nov 17, 2023

So with #72601, once that goes in I can update this with RUN line updates to test. It fails as expected without this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants