[libc++] Fixed uniform_real_distribution.h where it was allowing initialization with non floating point types #70485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
philnik777
requested changes
Oct 27, 2023
| @@ -27,6 +28,7 @@ _LIBCPP_BEGIN_NAMESPACE_STD | |||
| template<class _RealType = double> | |||
| class _LIBCPP_TEMPLATE_VIS uniform_real_distribution | |||
| { | |||
| static_assert(std::is_floating_point<_RealType>::value, "result_type must be a floating point type"); | |||
There was a problem hiding this comment.
This needs a test. You can take a look at libcxx/test/libcxx/input.output/iostream.format/input.streams/traits_mismatch.verify.cpp for an example of how to check static assertions.
|
You should also mention the issue in the description. |
|
Thank you for your guidance, I will do the required changes. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included a static_assert to deal with cases where result_types are initialized with non floating point type values which can cause undefined behaviour as mentioned here