Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply #2 [clang-repl] [test] Make an XFAIL more precise #71168

Merged
merged 1 commit into from
Nov 7, 2023

Commits on Nov 3, 2023

  1. Reapply llvm#2 [clang-repl] [test] Make an XFAIL more precise (llvm#7…

    …0991)
    
    The const.cpp testcase fails when running in MSVC mode, while it does
    succeed in MinGW mode.
    
    In MSVC mode, there are more constructor invocations than expected, as
    the printout looks like this:
    
        A(1), this = 0000025597930000
        A(1), this = 0000025597930000
        f: this = 0000025597930000, val = 1
        A(1), this = 0000025597930000
        f: this = 0000025597930000, val = 1
        ~A, this = 0000025597930000, val = 1
        ~A, this = 0000025597930000, val = 1
        ~A, this = 0000025597930000, val = 1
    
    While the expected printout looks like this:
    
        A(1), this = 000002C903E10000
        f: this = 000002C903E10000, val = 1
        f: this = 000002C903E10000, val = 1
        ~A, this = 000002C903E10000, val = 1
    
    Reapplying with the XFAIL changed to check the host triple,
    not the target triple. On an MSVC based build of Clang, but
    with the default target triple set to PS4/PS5, we will still
    see the failure. And a Linux based build of Clang that targets
    PS4/PS5 won't see the issue.
    mstorsjo committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    2fb453c View commit details
    Browse the repository at this point in the history