Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vectorize] Remove Transforms/Vectorize.h #71294

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

tstellar
Copy link
Collaborator

@tstellar tstellar commented Nov 4, 2023

The only thing in this file is a declaration for
createLoadStoreVectorizerPass(), and this function is already declared in LoadStoreVectorizer.h.

The only thing in this file is a declaration for
createLoadStoreVectorizerPass(), and this function is already declared
in LoadStoreVectorizer.h.
@llvmbot
Copy link
Collaborator

llvmbot commented Nov 4, 2023

@llvm/pr-subscribers-llvm-transforms

Author: Tom Stellard (tstellar)

Changes

The only thing in this file is a declaration for
createLoadStoreVectorizerPass(), and this function is already declared in LoadStoreVectorizer.h.


Full diff: https://github.com/llvm/llvm-project/pull/71294.diff

3 Files Affected:

  • (modified) llvm/include/llvm/LinkAllPasses.h (+1-1)
  • (removed) llvm/include/llvm/Transforms/Vectorize.h (-29)
  • (modified) llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp (-1)
diff --git a/llvm/include/llvm/LinkAllPasses.h b/llvm/include/llvm/LinkAllPasses.h
index 141b5420b925ca8..31adefe105f4d35 100644
--- a/llvm/include/llvm/LinkAllPasses.h
+++ b/llvm/include/llvm/LinkAllPasses.h
@@ -45,7 +45,7 @@
 #include "llvm/Transforms/Utils.h"
 #include "llvm/Transforms/Utils/SymbolRewriter.h"
 #include "llvm/Transforms/Utils/UnifyFunctionExitNodes.h"
-#include "llvm/Transforms/Vectorize.h"
+#include "llvm/Transforms/Vectorize/LoadStoreVectorizer.h"
 #include <cstdlib>
 
 namespace {
diff --git a/llvm/include/llvm/Transforms/Vectorize.h b/llvm/include/llvm/Transforms/Vectorize.h
deleted file mode 100644
index 1db501e0aeb0e0f..000000000000000
--- a/llvm/include/llvm/Transforms/Vectorize.h
+++ /dev/null
@@ -1,29 +0,0 @@
-//===-- Vectorize.h - Vectorization Transformations -------------*- C++ -*-===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-//
-// This header file defines prototypes for accessor functions that expose passes
-// in the Vectorize transformations library.
-//
-//===----------------------------------------------------------------------===//
-
-#ifndef LLVM_TRANSFORMS_VECTORIZE_H
-#define LLVM_TRANSFORMS_VECTORIZE_H
-
-namespace llvm {
-class Pass;
-
-//===----------------------------------------------------------------------===//
-//
-// LoadStoreVectorizer - Create vector loads and stores, but leave scalar
-// operations.
-//
-Pass *createLoadStoreVectorizerPass();
-
-} // End llvm namespace
-
-#endif
diff --git a/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp b/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
index 73a80702671922b..c0dbd52acbabe5b 100644
--- a/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
@@ -103,7 +103,6 @@
 #include "llvm/Support/ModRef.h"
 #include "llvm/Support/raw_ostream.h"
 #include "llvm/Transforms/Utils/Local.h"
-#include "llvm/Transforms/Vectorize.h"
 #include <algorithm>
 #include <cassert>
 #include <cstdint>

Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bjope
Copy link
Collaborator

bjope commented Nov 6, 2023

I happened to notice that there is a reference to the removed file in utils/bazel/llvm-project-overlay/llvm/BUILD.bazel as well. But I guess those bazel files still might be someone elses problem.

@tstellar
Copy link
Collaborator Author

tstellar commented Nov 6, 2023

I happened to notice that there is a reference to the removed file in utils/bazel/llvm-project-overlay/llvm/BUILD.bazel as well. But I guess those bazel files still might be someone elses problem.

The bazel files are usually updated post-commit.

@tstellar tstellar merged commit 2400c54 into llvm:main Nov 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants