[clang][docs] Improve "Obtaining Clang" section

[robincaloudis]

Why

The documentation is written relatively to clang-llvm, not the root repository directory. However, some steps in the documentation are relative to the repository root, which is not correct.

What

Documentation steps have been modified to make them correct and outdated ones were updated. Some details:

• Correct paths in documentation
• Change bootstrap.py -> configure.py since bootstraping Ninja has slightly changed

[llvmbot]

@llvm/pr-subscribers-clang

Author: Robin Caloudis (robincaloudis)

Changes

The documentation is written relatively to clang-llvm, not the root repository directory. Therefore, the llvm-project repo needs to be cloned into the existing directory clang-llvm. As cloning into an existing directory is only allowed if the directory is empty, I added mkdir ~/clang-llvm to make the intent of creating an empty directory explicit.

---

Full diff: https://github.com/llvm/llvm-project/pull/71313.diff

1 Files Affected:

• (modified) clang/docs/LibASTMatchersTutorial.rst (+2-2)

diff --git a/clang/docs/LibASTMatchersTutorial.rst b/clang/docs/LibASTMatchersTutorial.rst
index 37c9f178fa8df31..2a3f052f2e9ce15 100644
--- a/clang/docs/LibASTMatchersTutorial.rst
+++ b/clang/docs/LibASTMatchersTutorial.rst
@@ -22,8 +22,8 @@ started guide <https://llvm.org/docs/GettingStarted.html>`_.
 
 .. code-block:: console
 
-      cd ~/clang-llvm
-      git clone https://github.com/llvm/llvm-project.git
+      mkdir ~/clang-llvm && cd ~/clang-llvm
+      git clone https://github.com/llvm/llvm-project.git .
 
 Next you need to obtain the CMake build system and Ninja build tool.
 

[robincaloudis]

@r4nt, could you please review? Thank you.

[robincaloudis]

Ping.

[robincaloudis]

Ping

[Endilll]

LGTM, but wair for other reviewers.

[jrtc27]

Given the:

      cd ~/clang-llvm
      git clone git://cmake.org/stage/cmake.git

(which will clash with the cmake/ in llvm-project's root) this isn't a good idea. Better to clone it to an llvm-project subdirectory (i.e. drop the .) and alter later steps.

[robincaloudis]

Thanks for the review @jrtc27. Indeed, having the llvm-project subdirectory is much cleaner. I updated all required steps. Found some more outdated details. Updated PR description. Please re-review. Thank you.

[jrtc27]

Thanks, this looks better now

[jrtc27]

Though please make sure to update the PR message (which will become the commit message) before merging, as it's no longer accurate

[robincaloudis]

Though please make sure to update the PR message (which will become the commit message) before merging, as it's no longer accurate

Thanks. Updated it.

[robincaloudis]

@jrtc27, I do not have write access. All checks passed. Can you merge the PR? Thanks.